diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-01-21 14:02:58 +0100 |
---|---|---|
committer | Roland Dreier <roland@purestorage.com> | 2013-02-16 00:23:26 +0100 |
commit | 6950a235b86cf4e73d2b8e5476e7d0eb8f61af63 (patch) | |
tree | 5388c52e93d1c3be64d64ff9666536b31c10211f /drivers/infiniband/hw/mlx4/qp.c | |
parent | IB/mlx4: Fix bug unwinding on error in mlx4_ib_init_sriov() (diff) | |
download | linux-6950a235b86cf4e73d2b8e5476e7d0eb8f61af63.tar.xz linux-6950a235b86cf4e73d2b8e5476e7d0eb8f61af63.zip |
IB/mlx4: Adjust duplicate test
Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/hw/mlx4/qp.c')
0 files changed, 0 insertions, 0 deletions