diff options
| author | Michael Guralnik <michaelgur@nvidia.com> | 2024-09-03 13:24:48 +0200 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2024-09-09 20:17:09 +0200 |
| commit | 6f5cd6ac9a4201e4ba6f10b76a9da8044d6e38b0 (patch) | |
| tree | a61007afb192194e8b159cd4ef22e1fa0988c73e /drivers/infiniband/hw/mlx5/mr.c | |
| parent | RDMA/mlx5: Drop redundant work canceling from clean_keys() (diff) | |
| download | linux-6f5cd6ac9a4201e4ba6f10b76a9da8044d6e38b0.tar.xz linux-6f5cd6ac9a4201e4ba6f10b76a9da8044d6e38b0.zip | |
RDMA/mlx5: Fix counter update on MR cache mkey creation
After an mkey is created, update the counter for pending mkeys before
reshceduling the work that is filling the cache.
Rescheduling the work with a full MR cache entry and a wrong 'pending'
counter will cause us to miss disabling the fill_to_high_water flag.
Thus leaving the cache full but with an indication that it's still
needs to be filled up to it's full size (2 * limit).
Next time an mkey will be taken from the cache, we'll unnecessarily
continue the process of filling the cache to it's full size.
Fixes: 57e7071683ef ("RDMA/mlx5: Implement mkeys management via LIFO queue")
Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
Link: https://patch.msgid.link/0f44f462ba22e45f72cb3d0ec6a748634086b8d0.1725362530.git.leon@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/hw/mlx5/mr.c')
| -rw-r--r-- | drivers/infiniband/hw/mlx5/mr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 511d50491352..0f90086327fc 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -214,9 +214,9 @@ static void create_mkey_callback(int status, struct mlx5_async_work *context) spin_lock_irqsave(&ent->mkeys_queue.lock, flags); push_mkey_locked(ent, mkey_out->mkey); + ent->pending--; /* If we are doing fill_to_high_water then keep going. */ queue_adjust_cache_locked(ent); - ent->pending--; spin_unlock_irqrestore(&ent->mkeys_queue.lock, flags); kfree(mkey_out); } |