diff options
| author | Roland Dreier <rolandd@cisco.com> | 2006-03-20 19:08:25 +0100 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2006-03-20 19:08:25 +0100 |
| commit | 6b63e3015a69dd8aa5534e23af9f132a021da02e (patch) | |
| tree | 58c8ffeaf4a46e4ac5af98ebbaae7543c43561a9 /drivers/infiniband | |
| parent | IB: Coverity fixes to sysfs.c (diff) | |
| download | linux-6b63e3015a69dd8aa5534e23af9f132a021da02e.tar.xz linux-6b63e3015a69dd8aa5534e23af9f132a021da02e.zip | |
IB/mthca: Coverity fix to mthca_init_eq_table()
Fix bug found by coverity: the loop body never executed, because it
was doing for (i = 0; i < MTHCA_EQ_CMD; ++i), but MTHCA_EQ_CMD is 0.
The correct loop bound is MTHCA_NUM_EQ, to loop over all EQs.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/hw/mthca/mthca_eq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c index a44b12dd7952..cbdc348fb689 100644 --- a/drivers/infiniband/hw/mthca/mthca_eq.c +++ b/drivers/infiniband/hw/mthca/mthca_eq.c @@ -928,7 +928,7 @@ int __devinit mthca_init_eq_table(struct mthca_dev *dev) mthca_warn(dev, "MAP_EQ for cmd EQ %d returned status 0x%02x\n", dev->eq_table.eq[MTHCA_EQ_CMD].eqn, status); - for (i = 0; i < MTHCA_EQ_CMD; ++i) + for (i = 0; i < MTHCA_NUM_EQ; ++i) if (mthca_is_memfree(dev)) arbel_eq_req_not(dev, dev->eq_table.eq[i].eqn_mask); else |