diff options
| author | David S. Miller <davem@davemloft.net> | 2012-04-02 02:19:38 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 10:33:42 +0200 |
| commit | 4e24ffa4d9fed762147c954755f8cb124e85740a (patch) | |
| tree | 2fc068defe8cb4f45df31650f7e3d262f5e89ba7 /drivers/infiniband | |
| parent | crypto: Stop using NLA_PUT*(). (diff) | |
| download | linux-4e24ffa4d9fed762147c954755f8cb124e85740a.tar.xz linux-4e24ffa4d9fed762147c954755f8cb124e85740a.zip | |
infiniband: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/netlink.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c index 396e29370304..e497dfbee435 100644 --- a/drivers/infiniband/core/netlink.c +++ b/drivers/infiniband/core/netlink.c @@ -125,7 +125,8 @@ int ibnl_put_attr(struct sk_buff *skb, struct nlmsghdr *nlh, unsigned char *prev_tail; prev_tail = skb_tail_pointer(skb); - NLA_PUT(skb, type, len, data); + if (nla_put(skb, type, len, data)) + goto nla_put_failure; nlh->nlmsg_len += skb_tail_pointer(skb) - prev_tail; return 0; |