diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-11-04 19:27:32 +0100 |
|---|---|---|
| committer | Roland Dreier <roland@purestorage.com> | 2012-02-03 18:07:00 +0100 |
| commit | 3af336376f77859da84bb1156ef29d5337b316a9 (patch) | |
| tree | 31e6e0efc8b66c2212f834aeaa041052febd5076 /drivers/infiniband | |
| parent | IB/srpt: Remove unneeded <linux/version.h> include (diff) | |
| download | linux-3af336376f77859da84bb1156ef29d5337b316a9.tar.xz linux-3af336376f77859da84bb1156ef29d5337b316a9.zip | |
IB/srpt: Fix ERR_PTR() vs. NULL checking confusion
transport_init_session() and target_fabric_configfs_init() don't
return NULL pointers, they only return ERR_PTRs or valid pointers.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/ulp/srpt/ib_srpt.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 38ef61dbee0a..c125614ac256 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2595,7 +2595,7 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id, } ch->sess = transport_init_session(); - if (!ch->sess) { + if (IS_ERR(ch->sess)) { rej->reason = __constant_cpu_to_be32( SRP_LOGIN_REJ_INSUFFICIENT_RESOURCES); pr_debug("Failed to create session\n"); @@ -4009,10 +4009,10 @@ static int __init srpt_init_module(void) goto out; } - ret = -ENODEV; srpt_target = target_fabric_configfs_init(THIS_MODULE, "srpt"); - if (!srpt_target) { + if (IS_ERR(srpt_target)) { printk(KERN_ERR "couldn't register\n"); + ret = PTR_ERR(srpt_target); goto out; } |