diff options
| author | Dmitry Torokhov <dtor@insightbb.com> | 2007-06-04 05:29:36 +0200 |
|---|---|---|
| committer | Dmitry Torokhov <dtor@insightbb.com> | 2007-06-04 05:50:05 +0200 |
| commit | 1dfa2812404c37d7571622195f907cea3331616c (patch) | |
| tree | 2533af73ff0e1e4d24603967bd6cdc092973dce9 /drivers/input/joydev.c | |
| parent | Input: ucb1x00 - do not access input_dev->private directly (diff) | |
| download | linux-1dfa2812404c37d7571622195f907cea3331616c.tar.xz linux-1dfa2812404c37d7571622195f907cea3331616c.zip | |
Input: reduce raciness when input handlers disconnect
There is a race between input handler's release() and disconnect()
methods: when input handler disconnects it wakes up all regular
users and then process to walk user list to wake up async. users.
While disconnect() walks the list release() removes elements of
the same list causing oopses.
While this is not a substibute for proper locking we can reduce
odds of getting an oops if we wake up normal readers after walking
the list.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/joydev.c')
| -rw-r--r-- | drivers/input/joydev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c index 9bcc5425049b..c83bfe8914ac 100644 --- a/drivers/input/joydev.c +++ b/drivers/input/joydev.c @@ -595,9 +595,9 @@ static void joydev_disconnect(struct input_handle *handle) if (joydev->open) { input_close_device(handle); - wake_up_interruptible(&joydev->wait); list_for_each_entry(client, &joydev->client_list, node) kill_fasync(&client->fasync, SIGIO, POLL_HUP); + wake_up_interruptible(&joydev->wait); } else joydev_free(joydev); } |