summaryrefslogtreecommitdiffstats
path: root/drivers/input/misc
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor_core@ameritech.net>2005-10-18 01:43:32 +0200
committerLinus Torvalds <torvalds@g5.osdl.org>2005-10-18 02:03:57 +0200
commite7507ed91e093b9e4e218e41ebfdce05458258fc (patch)
treec2e89b585e9153677d626bb7dfe7ef12426016a0 /drivers/input/misc
parent[PATCH] Fix /proc/acpi/events around suspend (diff)
downloadlinux-e7507ed91e093b9e4e218e41ebfdce05458258fc.tar.xz
linux-e7507ed91e093b9e4e218e41ebfdce05458258fc.zip
[PATCH] uniput - fix crash on SMP
Only signal completion after marking request slot as free, otherwise other processor can free request structure before we finish using it. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/input/misc')
-rw-r--r--drivers/input/misc/uinput.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index d5c5b32045af..4015a91f4b6e 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -90,11 +90,11 @@ static inline int uinput_request_reserve_slot(struct uinput_device *udev, struct
static void uinput_request_done(struct uinput_device *udev, struct uinput_request *request)
{
- complete(&request->done);
-
/* Mark slot as available */
udev->requests[request->id] = NULL;
wake_up_interruptible(&udev->requests_waitq);
+
+ complete(&request->done);
}
static int uinput_request_submit(struct input_dev *dev, struct uinput_request *request)