summaryrefslogtreecommitdiffstats
path: root/drivers/input/touchscreen/ad7877.c
diff options
context:
space:
mode:
authorMark Brown <broonie@linaro.org>2014-04-25 08:37:56 +0200
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2014-05-15 01:39:47 +0200
commitc728601ea3531dc1f0dcd74c1db1e85e59f2be68 (patch)
tree2dda2b29bb64297694edea6c4e96d5bdca8bd343 /drivers/input/touchscreen/ad7877.c
parentInput: evdev - get rid of old workaround for EVIOCGBIT (diff)
downloadlinux-c728601ea3531dc1f0dcd74c1db1e85e59f2be68.tar.xz
linux-c728601ea3531dc1f0dcd74c1db1e85e59f2be68.zip
Input: ads7877 - remove bitrotted comment
While searching for users of spi_async() I found a reference in the ad7877 driver to using it to initiate data transfer from the interrupt handler. However there is no code for this, instead the interrupt handler is a threaded handler and uses spi_sync() instead. Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI. This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead. Signed-off-by: Mark Brown <broonie@linaro.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/touchscreen/ad7877.c')
-rw-r--r--drivers/input/touchscreen/ad7877.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index 6793c85903ae..523865daa1d3 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -210,11 +210,6 @@ static bool gpio3;
module_param(gpio3, bool, 0);
MODULE_PARM_DESC(gpio3, "If gpio3 is set to 1 AUX3 acts as GPIO3");
-/*
- * ad7877_read/write are only used for initial setup and for sysfs controls.
- * The main traffic is done using spi_async() in the interrupt handler.
- */
-
static int ad7877_read(struct spi_device *spi, u16 reg)
{
struct ser_req *req;