summaryrefslogtreecommitdiffstats
path: root/drivers/input/touchscreen/fsl-imx25-tcq.c
diff options
context:
space:
mode:
authorStephen Boyd <swboyd@chromium.org>2019-08-14 19:46:38 +0200
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2019-08-14 19:49:01 +0200
commit0bec8b7e5ca1a629f26173691526432f9d7cf8c1 (patch)
tree8b002ce844e53e1de228c0c581553473e948d86f /drivers/input/touchscreen/fsl-imx25-tcq.c
parentInput: applespi - no need to check return value of debugfs_create functions (diff)
downloadlinux-0bec8b7e5ca1a629f26173691526432f9d7cf8c1.tar.xz
linux-0bec8b7e5ca1a629f26173691526432f9d7cf8c1.zip
Input: remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/touchscreen/fsl-imx25-tcq.c')
-rw-r--r--drivers/input/touchscreen/fsl-imx25-tcq.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
index b66df8ab89f2..60a7246c5157 100644
--- a/drivers/input/touchscreen/fsl-imx25-tcq.c
+++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
@@ -526,10 +526,8 @@ static int mx25_tcq_probe(struct platform_device *pdev)
}
priv->irq = platform_get_irq(pdev, 0);
- if (priv->irq <= 0) {
- dev_err(dev, "Failed to get IRQ\n");
+ if (priv->irq <= 0)
return priv->irq;
- }
idev = devm_input_allocate_device(dev);
if (!idev) {