diff options
| author | Ben Nizette <bn@niasdigital.com> | 2009-04-18 05:35:57 +0200 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2009-04-18 05:41:54 +0200 |
| commit | e4bd3e591c8cc52ccf7a0b27f33aa7a5a19058d7 (patch) | |
| tree | 45288c39392bcb0f1c0993863cc3492c01109f13 /drivers/input | |
| parent | Input: omap-keypad - use disable_irq_nosync() in irq handler (diff) | |
| download | linux-e4bd3e591c8cc52ccf7a0b27f33aa7a5a19058d7.tar.xz linux-e4bd3e591c8cc52ccf7a0b27f33aa7a5a19058d7.zip | |
Input: sa1111ps2 - use disable_irq_nosync() in irq handlers
disable_irq() waits for all running handlers to complete before
returning. As such, if it's used to disable an interrupt from
that interrupt's handler it will deadlock. This replaces the
dangerous instances with the _nosync() variant which doesn't have
this problem.
Signed-off-by: Ben Nizette <bn@niasdigital.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/serio/sa1111ps2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c index 57953c0eb82f..f412c69478a8 100644 --- a/drivers/input/serio/sa1111ps2.c +++ b/drivers/input/serio/sa1111ps2.c @@ -77,7 +77,7 @@ static irqreturn_t ps2_txint(int irq, void *dev_id) spin_lock(&ps2if->lock); status = sa1111_readl(ps2if->base + SA1111_PS2STAT); if (ps2if->head == ps2if->tail) { - disable_irq(irq); + disable_irq_nosync(irq); /* done */ } else if (status & PS2STAT_TXE) { sa1111_writel(ps2if->buf[ps2if->tail], ps2if->base + SA1111_PS2DATA); |