diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 20:34:13 +0200 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2018-07-27 20:59:09 +0200 |
| commit | 434ca100cfa50de354d88329d7c0a10b80241f10 (patch) | |
| tree | 028ab67de85ecaaba798e1d2b6fafbed0572ae1c /drivers/input | |
| parent | Input: powermate - replace GFP_ATOMIC with GFP_KERNEL in powermate_alloc_buff... (diff) | |
| download | linux-434ca100cfa50de354d88329d7c0a10b80241f10.tar.xz linux-434ca100cfa50de354d88329d7c0a10b80241f10.zip | |
Input: yealink - replace GFP_ATOMIC with GFP_KERNEL in usb_probe()
usb_probe() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/misc/yealink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c index f0c9bf87b4e3..1365cd94ed9b 100644 --- a/drivers/input/misc/yealink.c +++ b/drivers/input/misc/yealink.c @@ -894,12 +894,12 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) /* allocate usb buffers */ yld->irq_data = usb_alloc_coherent(udev, USB_PKT_LEN, - GFP_ATOMIC, &yld->irq_dma); + GFP_KERNEL, &yld->irq_dma); if (yld->irq_data == NULL) return usb_cleanup(yld, -ENOMEM); yld->ctl_data = usb_alloc_coherent(udev, USB_PKT_LEN, - GFP_ATOMIC, &yld->ctl_dma); + GFP_KERNEL, &yld->ctl_dma); if (!yld->ctl_data) return usb_cleanup(yld, -ENOMEM); |