summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-12-19 18:22:21 +0100
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2015-12-20 08:44:40 +0100
commit8dcb3c7628f19192dd568fbee9094a2d4b14b6af (patch)
treee92e2afc46f46c3c89bf9b3b8928480bb14c4b3e /drivers/input
parentInput: uinput - sanity check on ff_effects_max and EV_FF (diff)
downloadlinux-8dcb3c7628f19192dd568fbee9094a2d4b14b6af.tar.xz
linux-8dcb3c7628f19192dd568fbee9094a2d4b14b6af.zip
Input: egalax_ts_serial - fix potential NULL dereference on error
We didn't check input_allocate_device() for failures so it could lead to a NULL deref. Fixes: 6b0f8f9c52ef ('Input: add eGalaxTouch serial touchscreen driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/touchscreen/egalax_ts_serial.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/touchscreen/egalax_ts_serial.c b/drivers/input/touchscreen/egalax_ts_serial.c
index a078c1c2c3f9..657bbae608c8 100644
--- a/drivers/input/touchscreen/egalax_ts_serial.c
+++ b/drivers/input/touchscreen/egalax_ts_serial.c
@@ -105,7 +105,7 @@ static int egalax_connect(struct serio *serio, struct serio_driver *drv)
egalax = kzalloc(sizeof(struct egalax), GFP_KERNEL);
input_dev = input_allocate_device();
- if (!egalax) {
+ if (!egalax || !input_dev) {
error = -ENOMEM;
goto err_free_mem;
}