summaryrefslogtreecommitdiffstats
path: root/drivers/iommu/amd_iommu_v2.c
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2017-04-23 12:23:21 +0200
committerJoerg Roedel <jroedel@suse.de>2017-04-24 12:33:34 +0200
commit73dbd4a4230216b6a5540a362edceae0c9b4876b (patch)
tree1af257e9a90628ab2e0e97ba87cbe342764fc455 /drivers/iommu/amd_iommu_v2.c
parentLinux 4.11-rc8 (diff)
downloadlinux-73dbd4a4230216b6a5540a362edceae0c9b4876b.tar.xz
linux-73dbd4a4230216b6a5540a362edceae0c9b4876b.zip
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes the bug. Signed-off-by: Pan Bian <bianpan2016@163.com> Fixes: f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct') Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/amd_iommu_v2.c')
-rw-r--r--drivers/iommu/amd_iommu_v2.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 063343909b0d..6629c472eafd 100644
--- a/drivers/iommu/amd_iommu_v2.c
+++ b/drivers/iommu/amd_iommu_v2.c
@@ -696,9 +696,9 @@ out_clear_state:
out_unregister:
mmu_notifier_unregister(&pasid_state->mn, mm);
+ mmput(mm);
out_free:
- mmput(mm);
free_pasid_state(pasid_state);
out: