diff options
| author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-08-01 08:18:38 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2016-08-09 17:27:48 +0200 |
| commit | 423595e89ddf9b657812a33932a5e2ad1bb9dd54 (patch) | |
| tree | 99623022f61aca32374c0c58a338da06cd17b0c2 /drivers/iommu/exynos-iommu.c | |
| parent | Linux 4.8-rc1 (diff) | |
| download | linux-423595e89ddf9b657812a33932a5e2ad1bb9dd54.tar.xz linux-423595e89ddf9b657812a33932a5e2ad1bb9dd54.zip | |
iommu/exynos: Fix error handling for of_platform_device_create
of_platform_device_create returns NULL on error so an IS_ERR test is
incorrect here and a NULL check is required.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression e;
@@
e = of_platform_device_create(...);
if(
- IS_ERR(e)
+ !e
)
{
<+...
return
- PTR_ERR(e)
+ -ENODEV
;
...+>
}
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/exynos-iommu.c')
| -rw-r--r-- | drivers/iommu/exynos-iommu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 33dcc29ec200..30808e91b775 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1345,8 +1345,8 @@ static int __init exynos_iommu_of_setup(struct device_node *np) exynos_iommu_init(); pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); - if (IS_ERR(pdev)) - return PTR_ERR(pdev); + if (!pdev) + return -ENODEV; /* * use the first registered sysmmu device for performing |