summaryrefslogtreecommitdiffstats
path: root/drivers/iommu/fsl_pamu.c
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-11-21 09:20:22 +0100
committerJoerg Roedel <jroedel@suse.de>2022-11-22 15:51:31 +0100
commit73f5fc5f884ad0c5f7d57f66303af64f9f002526 (patch)
treeceb729426b77290437bf1d4390550f367f5497b1 /drivers/iommu/fsl_pamu.c
parentiommu/fsl_pamu: Replace NO_IRQ by 0 (diff)
downloadlinux-73f5fc5f884ad0c5f7d57f66303af64f9f002526.tar.xz
linux-73f5fc5f884ad0c5f7d57f66303af64f9f002526.zip
iommu/fsl_pamu: Fix resource leak in fsl_pamu_probe()
The fsl_pamu_probe() returns directly when create_csd() failed, leaving irq and memories unreleased. Fix by jumping to error if create_csd() returns error. Fixes: 695093e38c3e ("iommu/fsl: Freescale PAMU driver and iommu implementation.") Signed-off-by: Yuan Can <yuancan@huawei.com> Link: https://lore.kernel.org/r/20221121082022.19091-1-yuancan@huawei.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/fsl_pamu.c')
-rw-r--r--drivers/iommu/fsl_pamu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 1b53d2da2c19..1a8c85d54123 100644
--- a/drivers/iommu/fsl_pamu.c
+++ b/drivers/iommu/fsl_pamu.c
@@ -868,7 +868,7 @@ static int fsl_pamu_probe(struct platform_device *pdev)
ret = create_csd(ppaact_phys, mem_size, csd_port_id);
if (ret) {
dev_err(dev, "could not create coherence subdomain\n");
- return ret;
+ goto error;
}
}