diff options
| author | Robin Murphy <robin.murphy@arm.com> | 2017-10-18 16:04:28 +0200 |
|---|---|---|
| committer | Will Deacon <will.deacon@arm.com> | 2017-10-20 17:55:10 +0200 |
| commit | 8ff0f72371709889349a706e19bb38d9f71b1669 (patch) | |
| tree | 29e961ad097c47c29ddbaf679e57ad4c2ba229dc /drivers/iommu | |
| parent | iommu/arm-smmu-v3: Consolidate identical timeouts (diff) | |
| download | linux-8ff0f72371709889349a706e19bb38d9f71b1669.tar.xz linux-8ff0f72371709889349a706e19bb38d9f71b1669.zip | |
iommu/arm-smmu-v3: Use burst-polling for sync completion
While CMD_SYNC is unlikely to complete immediately such that we never go
round the polling loop, with a lightly-loaded queue it may still do so
long before the delay period is up. If we have no better completion
notifier, use similar logic as we have for SMMUv2 to spin a number of
times before each backoff, so that we have more chance of catching syncs
which complete relatively quickly and avoid delaying unnecessarily.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/arm-smmu-v3.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index c148f76dd8e2..bfab719190e8 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -419,6 +419,7 @@ /* High-level queue structures */ #define ARM_SMMU_POLL_TIMEOUT_US 100 #define ARM_SMMU_CMDQ_SYNC_TIMEOUT_US 1000000 /* 1s! */ +#define ARM_SMMU_CMDQ_SYNC_SPIN_COUNT 10 #define MSI_IOVA_BASE 0x8000000 #define MSI_IOVA_LENGTH 0x100000 @@ -769,7 +770,7 @@ static void queue_inc_prod(struct arm_smmu_queue *q) static int queue_poll_cons(struct arm_smmu_queue *q, bool sync, bool wfe) { ktime_t timeout; - unsigned int delay = 1; + unsigned int delay = 1, spin_cnt = 0; /* Wait longer if it's a CMD_SYNC */ timeout = ktime_add_us(ktime_get(), sync ? @@ -782,10 +783,13 @@ static int queue_poll_cons(struct arm_smmu_queue *q, bool sync, bool wfe) if (wfe) { wfe(); - } else { + } else if (++spin_cnt < ARM_SMMU_CMDQ_SYNC_SPIN_COUNT) { cpu_relax(); + continue; + } else { udelay(delay); delay *= 2; + spin_cnt = 0; } } |