diff options
author | Peng Fan <van.freenix@gmail.com> | 2016-07-13 04:13:08 +0200 |
---|---|---|
committer | Will Deacon <will.deacon@arm.com> | 2016-09-16 10:34:12 +0200 |
commit | e2d42311ffc9a5014eb129d02eb0e7bc791430f0 (patch) | |
tree | 04f41a7b7e5fcd9d551a586ec6249ee25338c7fd /drivers/iommu | |
parent | Linux 4.8-rc4 (diff) | |
download | linux-e2d42311ffc9a5014eb129d02eb0e7bc791430f0.tar.xz linux-e2d42311ffc9a5014eb129d02eb0e7bc791430f0.zip |
iommu/arm-smmu: Drop devm_free_irq when driver detach
There is no need to call devm_free_irq when driver detach.
devres_release_all which is called after 'drv->remove' will
release all managed resources.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'drivers/iommu')
-rw-r--r-- | drivers/iommu/arm-smmu.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 2db74ebc3240..069b2ea89113 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -1998,7 +1998,6 @@ out_put_masters: static int arm_smmu_device_remove(struct platform_device *pdev) { - int i; struct device *dev = &pdev->dev; struct arm_smmu_device *curr, *smmu = NULL; struct rb_node *node; @@ -2025,9 +2024,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev) if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) dev_err(dev, "removing device with active domains!\n"); - for (i = 0; i < smmu->num_global_irqs; ++i) - devm_free_irq(smmu->dev, smmu->irqs[i], smmu); - /* Turn the thing off */ writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); return 0; |