diff options
| author | Heiko Stuebner <heiko@sntech.de> | 2018-04-17 14:09:15 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2018-05-03 16:32:10 +0200 |
| commit | 2f8c7f2e76bf040fcdaa2b4f4c2b9ef3b6e4ed25 (patch) | |
| tree | 3b415f714fbd859bfdcf936cd8004f384854806f /drivers/iommu | |
| parent | iommu/amd: Hide unused iommu_table_lock (diff) | |
| download | linux-2f8c7f2e76bf040fcdaa2b4f4c2b9ef3b6e4ed25.tar.xz linux-2f8c7f2e76bf040fcdaa2b4f4c2b9ef3b6e4ed25.zip | |
iommu/rockchip: Make clock handling optional
iommu clocks are optional, so the driver should not fail if they are not
present. Instead just set the number of clocks to 0, which the clk-blk APIs
can handle just fine.
Fixes: f2e3a5f557ad ("iommu/rockchip: Control clocks needed to access the IOMMU")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/rockchip-iommu.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 5fc8656c60f9..c0f03af34832 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@ -1175,8 +1175,15 @@ static int rk_iommu_probe(struct platform_device *pdev) for (i = 0; i < iommu->num_clocks; ++i) iommu->clocks[i].id = rk_iommu_clocks[i]; + /* + * iommu clocks should be present for all new devices and devicetrees + * but there are older devicetrees without clocks out in the wild. + * So clocks as optional for the time being. + */ err = devm_clk_bulk_get(iommu->dev, iommu->num_clocks, iommu->clocks); - if (err) + if (err == -ENOENT) + iommu->num_clocks = 0; + else if (err) return err; err = clk_bulk_prepare(iommu->num_clocks, iommu->clocks); |