diff options
| author | Joerg Roedel <jroedel@suse.de> | 2015-10-20 17:33:37 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2015-10-21 11:29:27 +0200 |
| commit | 272e4f99e966989394b167b695ab489c60fe1243 (patch) | |
| tree | 968b6a285de4555ccd870500f0c46b330062b5c8 /drivers/iommu | |
| parent | iommu/amd: Don't disable IRQs in __detach_device (diff) | |
| download | linux-272e4f99e966989394b167b695ab489c60fe1243.tar.xz linux-272e4f99e966989394b167b695ab489c60fe1243.zip | |
iommu/amd: WARN when __[attach|detach]_device are called with irqs enabled
These functions rely on being called with IRQs disabled. Add
a WARN_ON to detect early when its not.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/amd_iommu.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 07f491c2dc64..f8f54a4b1d8f 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -2030,6 +2030,12 @@ static int __attach_device(struct iommu_dev_data *dev_data, { int ret; + /* + * Must be called with IRQs disabled. Warn here to detect early + * when its not. + */ + WARN_ON(!irqs_disabled()); + /* lock domain */ spin_lock(&domain->lock); @@ -2190,6 +2196,12 @@ static void __detach_device(struct iommu_dev_data *dev_data) { struct protection_domain *domain; + /* + * Must be called with IRQs disabled. Warn here to detect early + * when its not. + */ + WARN_ON(!irqs_disabled()); + if (WARN_ON(!dev_data->domain)) return; |