diff options
| author | Jianmin Lv <lvjianmin@loongson.cn> | 2022-10-22 09:59:54 +0200 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-11-26 14:05:48 +0100 |
| commit | 25f3514aab3748bfef4a279ed599f836ac83e62a (patch) | |
| tree | 95747b95fc6d0fd7c57a8bc5437a37838a162b02 /drivers/irqchip/irq-loongson-pch-pic.c | |
| parent | irqchip/loongson-pch-pic: Fix translate callback for DT path (diff) | |
| download | linux-25f3514aab3748bfef4a279ed599f836ac83e62a.tar.xz linux-25f3514aab3748bfef4a279ed599f836ac83e62a.zip | |
irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path
For ACPI path, the translate callback used IRQ_TYPE_NONE and ignored
the IRQ type in fwspec->param[1]. For supporting to set type for
IRQs of the irqdomain, fwspec->param[1] should be used to get IRQ
type.
Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221022075955.11726-4-lvjianmin@loongson.cn
Diffstat (limited to 'drivers/irqchip/irq-loongson-pch-pic.c')
| -rw-r--r-- | drivers/irqchip/irq-loongson-pch-pic.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c index 03493cda65a3..a26a3f59d4a5 100644 --- a/drivers/irqchip/irq-loongson-pch-pic.c +++ b/drivers/irqchip/irq-loongson-pch-pic.c @@ -155,9 +155,6 @@ static int pch_pic_domain_translate(struct irq_domain *d, struct pch_pic *priv = d->host_data; struct device_node *of_node = to_of_node(fwspec->fwnode); - if (fwspec->param_count < 1) - return -EINVAL; - if (of_node) { if (fwspec->param_count < 2) return -EINVAL; @@ -165,8 +162,14 @@ static int pch_pic_domain_translate(struct irq_domain *d, *hwirq = fwspec->param[0] + priv->ht_vec_base; *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK; } else { + if (fwspec->param_count < 1) + return -EINVAL; + *hwirq = fwspec->param[0] - priv->gsi_base; - *type = IRQ_TYPE_NONE; + if (fwspec->param_count > 1) + *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK; + else + *type = IRQ_TYPE_NONE; } return 0; |