summaryrefslogtreecommitdiffstats
path: root/drivers/irqchip/irq-mtk-sysirq.c
diff options
context:
space:
mode:
authorMarc Zyngier <maz@kernel.org>2020-08-25 11:38:39 +0200
committerMarc Zyngier <maz@kernel.org>2020-08-25 11:48:54 +0200
commita150dac5a8fb711fdc378c23f44bee4546f04246 (patch)
tree35f14827291550c711217d04dedab847314ab5dd /drivers/irqchip/irq-mtk-sysirq.c
parentirqchip: Fix probing deferal when using IRQCHIP_PLATFORM_DRIVER helpers (diff)
downloadlinux-a150dac5a8fb711fdc378c23f44bee4546f04246.tar.xz
linux-a150dac5a8fb711fdc378c23f44bee4546f04246.zip
irqchip: Revert modular support for drivers using IRQCHIP_PLATFORM_DRIVER helperse
It has become obvious that switching a number of irqchip drivers to being platform drivers without considering the platform was a mistake. We have multiple reports of end-point drivers not probing because the irqchip driver isn't there yet, breaking the expectations of the users. This patch reverts: 920ecb8c35cb ("irqchip/mtk-cirq: Convert to a platform driver") f97dbf48ca43 ("irqchip/mtk-sysirq: Convert to a platform driver") 5be57099d445 ("irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros") 95bf9305d2e3 ("irqchip/qcom-pdc: Allow QCOM_PDC to be loadable as a permanent module") and leave QCOM PDC, MTK sysrq and cirq drivers as built-in, special purpose drivers for the time being until we have worked out a better solution. Reported-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reported-by: Frank Wunderlich <linux@fw-web.de> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/93debe6a0308b66d3f307af67ba7ec2c@kernel.org
Diffstat (limited to 'drivers/irqchip/irq-mtk-sysirq.c')
-rw-r--r--drivers/irqchip/irq-mtk-sysirq.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
index 7299c5ab4d10..6ff98b87e5c0 100644
--- a/drivers/irqchip/irq-mtk-sysirq.c
+++ b/drivers/irqchip/irq-mtk-sysirq.c
@@ -231,6 +231,4 @@ out_free_chip:
kfree(chip_data);
return ret;
}
-IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq)
-IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init)
-IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq)
+IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init);