diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2018-08-13 17:11:44 +0200 |
|---|---|---|
| committer | Marc Zyngier <marc.zyngier@arm.com> | 2018-08-13 17:20:17 +0200 |
| commit | f3b28362b683d8763e40ec9beee2f1d3bc616b8b (patch) | |
| tree | f3e5fb664a7553113e302514694cad5636351fea /drivers/irqchip/irq-s3c24xx.c | |
| parent | irqchip/stm32: Fix init error handling (diff) | |
| download | linux-f3b28362b683d8763e40ec9beee2f1d3bc616b8b.tar.xz linux-f3b28362b683d8763e40ec9beee2f1d3bc616b8b.zip | |
irqchip/s3c24xx: Remove unneeded comparison of unsigned long to 0
irq_data->hwirq is unsigned long. This fixes GCC warning:
drivers/irqchip/irq-s3c24xx.c: In function 's3c_irqext0_type':
drivers/irqchip/irq-s3c24xx.c:253:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
^~
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Diffstat (limited to 'drivers/irqchip/irq-s3c24xx.c')
| -rw-r--r-- | drivers/irqchip/irq-s3c24xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c index f6fd57ebe6e6..c19766fe8a1a 100644 --- a/drivers/irqchip/irq-s3c24xx.c +++ b/drivers/irqchip/irq-s3c24xx.c @@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type) void __iomem *gpcon_reg; unsigned long gpcon_offset, extint_offset; - if ((data->hwirq >= 0) && (data->hwirq <= 3)) { + if (data->hwirq <= 3) { gpcon_reg = S3C2410_GPFCON; extint_reg = S3C24XX_EXTINT0; gpcon_offset = (data->hwirq) * 2; |