diff options
| author | Marc Zyngier <maz@kernel.org> | 2020-03-04 21:33:09 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2020-03-19 12:21:58 +0100 |
| commit | 28d160de5194c68ff534443d2a8b6f1d10d57c58 (patch) | |
| tree | 5854b4b387b278e4f14f83f51b1b8a04c2740c42 /drivers/irqchip | |
| parent | irqchip/gic-v3: Use SGIs without active state if offered (diff) | |
| download | linux-28d160de5194c68ff534443d2a8b6f1d10d57c58.tar.xz linux-28d160de5194c68ff534443d2a8b6f1d10d57c58.zip | |
irqchip/gic-v4.1: Skip absent CPUs while iterating over redistributors
In a system that is only sparsly populated with CPUs, we can end-up with
redistributors structures that are not initialized. Let's make sure we
don't try and access those when iterating over them (in this case when
checking we have a L2 VPE table).
Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/20200304203330.4967-3-maz@kernel.org
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-gic-v3-its.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 83b1186ffcad..da883a691028 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2452,6 +2452,10 @@ static bool allocate_vpe_l2_table(int cpu, u32 id) if (!gic_rdists->has_rvpeid) return true; + /* Skip non-present CPUs */ + if (!base) + return true; + val = gicr_read_vpropbaser(base + SZ_128K + GICR_VPROPBASER); esz = FIELD_GET(GICR_VPROPBASER_4_1_ENTRY_SIZE, val) + 1; |