diff options
| author | Marc Zyngier <maz@kernel.org> | 2023-05-30 12:01:22 +0200 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2023-05-30 12:01:22 +0200 |
| commit | 91539341a3b6e9c868024a4292455dae36e6f58c (patch) | |
| tree | a433f4f10b0c9e0501c196ddb25ba01490bb2a98 /drivers/irqchip | |
| parent | irqchip/mbigen: Unify the error handling in mbigen_of_create_domain() (diff) | |
| download | linux-91539341a3b6e9c868024a4292455dae36e6f58c.tar.xz linux-91539341a3b6e9c868024a4292455dae36e6f58c.zip | |
irqchip/gic: Correctly validate OF quirk descriptors
When checking for OF quirks, make sure either 'compatible' or 'property'
is set, and give up otherwise.
This avoids non-OF quirks being randomly applied as they don't have any
of the OF data that need checking.
Cc: Douglas Anderson <dianders@chromium.org>
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 44bd78dd2b88 ("irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-gic-common.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c index de47b51cdadb..afd6a1841715 100644 --- a/drivers/irqchip/irq-gic-common.c +++ b/drivers/irqchip/irq-gic-common.c @@ -16,6 +16,8 @@ void gic_enable_of_quirks(const struct device_node *np, const struct gic_quirk *quirks, void *data) { for (; quirks->desc; quirks++) { + if (!quirks->compatible && !quirks->property) + continue; if (quirks->compatible && !of_device_is_compatible(np, quirks->compatible)) continue; |