diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 10:09:29 +0200 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-06-09 18:36:57 +0200 |
| commit | fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b (patch) | |
| tree | 6f66d9915cfaa36609fe76932da8d4b1f813bb65 /drivers/irqchip | |
| parent | irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions (diff) | |
| download | linux-fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b.tar.xz linux-fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b.zip | |
irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions
of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: e3825ba1af3a ("irqchip/gic-v3: Add support for partitioned PPIs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-gic-v3.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 1d5b4755a27e..5c1cf907ee68 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1973,12 +1973,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) continue; cpu = of_cpu_node_to_id(cpu_node); - if (WARN_ON(cpu < 0)) + if (WARN_ON(cpu < 0)) { + of_node_put(cpu_node); continue; + } pr_cont("%pOF[%d] ", cpu_node, cpu); cpumask_set_cpu(cpu, &part->mask); + of_node_put(cpu_node); } pr_cont("}\n"); |