summaryrefslogtreecommitdiffstats
path: root/drivers/isdn/hysdn/boardergo.h
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2010-08-09 18:05:43 +0200
committerAl Viro <viro@zeniv.linux.org.uk>2010-08-09 22:49:01 +0200
commit7a4dec53897ecd3367efb1e12fe8a4edc47dc0e9 (patch)
tree31d4639522e1453a7f5c38aa2436ffdd6df5c60b /drivers/isdn/hysdn/boardergo.h
parentvfs: don't hold s_umount over close_bdev_exclusive() call (diff)
downloadlinux-7a4dec53897ecd3367efb1e12fe8a4edc47dc0e9.tar.xz
linux-7a4dec53897ecd3367efb1e12fe8a4edc47dc0e9.zip
Fix sget() race with failing mount
If sget() finds a matching superblock being set up, it'll grab an active reference to it and grab s_umount. That's fine - we'll wait for completion of foofs_get_sb() that way. However, if said foofs_get_sb() fails we'll end up holding the halfway-created superblock. deactivate_locked_super() called by foofs_get_sb() will just unlock the sucker since we are holding another active reference to it. What we need is a way to tell if superblock has been successfully set up. Unfortunately, neither ->s_root nor the check for MS_ACTIVE quite fit. Cheap and easy way, suitable for backport: new flag set by the (only) caller of ->get_sb(). If that flag isn't present by the time sget() grabbed s_umount on preexisting superblock it has found, it's seeing a stillborn and should just bury it with deactivate_locked_super() (and repeat the search). Longer term we want to set that flag in ->get_sb() instances (and check for it to distinguish between "sget() found us a live sb" and "sget() has allocated an sb, we need to set it up" in there, instead of checking ->s_root as we do now). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Cc: stable@kernel.org
Diffstat (limited to 'drivers/isdn/hysdn/boardergo.h')
0 files changed, 0 insertions, 0 deletions