diff options
| author | Jeff Garzik <jeff@garzik.org> | 2006-10-17 09:10:40 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-17 17:18:49 +0200 |
| commit | 7786ce192fc4917fb9b789dd823476ff8fd6cf66 (patch) | |
| tree | 3ec803c1c77ff22bfe6076ea4d90a27f888b4fad /drivers/isdn/isdnloop | |
| parent | [PATCH] ISDN: fix drivers, by handling errors thrown by ->readstat() (diff) | |
| download | linux-7786ce192fc4917fb9b789dd823476ff8fd6cf66.tar.xz linux-7786ce192fc4917fb9b789dd823476ff8fd6cf66.zip | |
[PATCH] ISDN: check for userspace copy faults
Most of the ISDN ->readstat() implementations needed to check
copy_to_user() and put_user() return values.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/isdn/isdnloop')
| -rw-r--r-- | drivers/isdn/isdnloop/isdnloop.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/isdn/isdnloop/isdnloop.c b/drivers/isdn/isdnloop/isdnloop.c index 23afba46433e..c3ae2edaf6fa 100644 --- a/drivers/isdn/isdnloop/isdnloop.c +++ b/drivers/isdn/isdnloop/isdnloop.c @@ -446,7 +446,8 @@ isdnloop_readstatus(u_char __user *buf, int len, isdnloop_card * card) for (p = buf, count = 0; count < len; p++, count++) { if (card->msg_buf_read == card->msg_buf_write) return count; - put_user(*card->msg_buf_read++, p); + if (put_user(*card->msg_buf_read++, p)) + return -EFAULT; if (card->msg_buf_read > card->msg_buf_end) card->msg_buf_read = card->msg_buf; } |