diff options
| author | Dan Carpenter <error27@gmail.com> | 2009-11-04 17:27:09 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-04 17:27:09 +0100 |
| commit | 08cb3f60b2f866c906a5a779444b30ba8f9a93c8 (patch) | |
| tree | f4fbe2b67c16f411637416b2548389ff20559a3e /drivers/isdn/mISDN/stack.c | |
| parent | isdn: hisax: Fix lock imbalance. (diff) | |
| download | linux-08cb3f60b2f866c906a5a779444b30ba8f9a93c8.tar.xz linux-08cb3f60b2f866c906a5a779444b30ba8f9a93c8.zip | |
misdn: Fix reversed 'if' in st_own_ctrl
The current code probably returns -EINVAL a lot. Otherwise it would oops.
Compile tested only. Found by smatch (http://repo.or.cz/w/smatch.git).
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/mISDN/stack.c')
| -rw-r--r-- | drivers/isdn/mISDN/stack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/mISDN/stack.c b/drivers/isdn/mISDN/stack.c index 3e1532a180ff..0d05ec43012c 100644 --- a/drivers/isdn/mISDN/stack.c +++ b/drivers/isdn/mISDN/stack.c @@ -364,7 +364,7 @@ add_layer2(struct mISDNchannel *ch, struct mISDNstack *st) static int st_own_ctrl(struct mISDNchannel *ch, u_int cmd, void *arg) { - if (!ch->st || ch->st->layer1) + if (!ch->st || !ch->st->layer1) return -EINVAL; return ch->st->layer1->ctrl(ch->st->layer1, cmd, arg); } |