diff options
| author | Tilman Schmidt <tilman@imap.cc> | 2009-06-07 11:09:24 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-06-08 09:45:51 +0200 |
| commit | 7d31acda9f8eaa27e2fd232712f7e1f3e9a79bdb (patch) | |
| tree | 977fbd3081ba483b01c37dd1913ba4c9a0a95117 /drivers/isdn | |
| parent | isdn: kerneldoc for capiutil.c (diff) | |
| download | linux-7d31acda9f8eaa27e2fd232712f7e1f3e9a79bdb.tar.xz linux-7d31acda9f8eaa27e2fd232712f7e1f3e9a79bdb.zip | |
isdn: prevent NULL ptr Oops in capi_cmsg2str()
The dereferencing of the private pointer cmsg->m in capi_cmsg2str() may
cause an Oops in case of an error, which is particularly inconvenient
as that function is typically used to format an error message. Add a
NULL pointer check to avoid this.
Impact: error handling improvement
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/capi/capiutil.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c index c7c29022a23a..16f2e465e5f9 100644 --- a/drivers/isdn/capi/capiutil.c +++ b/drivers/isdn/capi/capiutil.c @@ -989,6 +989,8 @@ _cdebbuf *capi_cmsg2str(_cmsg * cmsg) { _cdebbuf *cdb; + if (!cmsg->m) + return NULL; /* no message */ cdb = cdebbuf_alloc(); if (!cdb) return NULL; |