summaryrefslogtreecommitdiffstats
path: root/drivers/leds/flash
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2023-03-17 20:13:41 +0100
committerLee Jones <lee@kernel.org>2023-03-30 14:58:24 +0200
commit22dc3789b737fe29d8f54f0d084047aede5550ad (patch)
treebada597f5c309cd2fae802843e65bfd1f618c2a9 /drivers/leds/flash
parentleds: rgb: mt6370: Correct config name to select in LEDS_MT6370_RGB (diff)
downloadlinux-22dc3789b737fe29d8f54f0d084047aede5550ad.tar.xz
linux-22dc3789b737fe29d8f54f0d084047aede5550ad.zip
leds: flash: Set variables mvflash_{3,4}ch_regs storage-class-specifier to static
Smatch reports: drivers/leds/flash/leds-qcom-flash.c:103:18: warning: symbol 'mvflash_3ch_regs' was not declared. Should it be static? drivers/leds/flash/leds-qcom-flash.c:115:18: warning: symbol 'mvflash_4ch_regs' was not declared. Should it be static? These variables are only used locally, so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230317191341.1670660-1-trix@redhat.com
Diffstat (limited to 'drivers/leds/flash')
-rw-r--r--drivers/leds/flash/leds-qcom-flash.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c
index 406ed8761c78..90a24fa25a49 100644
--- a/drivers/leds/flash/leds-qcom-flash.c
+++ b/drivers/leds/flash/leds-qcom-flash.c
@@ -100,7 +100,7 @@ enum {
REG_MAX_COUNT,
};
-struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
+static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x08, 0, 7), /* status1 */
REG_FIELD(0x09, 0, 7), /* status2 */
REG_FIELD(0x0a, 0, 7), /* status3 */
@@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x4c, 0, 2), /* chan_en */
};
-struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
+static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x06, 0, 7), /* status1 */
REG_FIELD(0x07, 0, 6), /* status2 */
REG_FIELD(0x09, 0, 7), /* status3 */