summaryrefslogtreecommitdiffstats
path: root/drivers/leds/leds-88pm860x.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-24 16:42:30 +0200
committerJacek Anaszewski <j.anaszewski@samsung.com>2015-11-03 09:00:06 +0100
commitffdc307d038f02617041f8e5c7e3cd00a1706a2a (patch)
treeb84ea75c62327c6f656994f4da5da045cb3cf721 /drivers/leds/leds-88pm860x.c
parentleds: bcm6328: add missing of_node_put (diff)
downloadlinux-ffdc307d038f02617041f8e5c7e3cd00a1706a2a.tar.xz
linux-ffdc307d038f02617041f8e5c7e3cd00a1706a2a.zip
leds: 88pm860x: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e,r; @@ for_each_child_of_node(r,n) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to '')
-rw-r--r--drivers/leds/leds-88pm860x.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1497a09166d6..7870840e7cc9 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -142,6 +142,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
of_property_read_u32(np, "marvell,88pm860x-iset",
&iset);
data->iset = PM8606_LED_CURRENT(iset);
+ of_node_put(np);
break;
}
}