diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2018-12-26 05:18:23 +0100 |
|---|---|---|
| committer | Jacek Anaszewski <jacek.anaszewski@gmail.com> | 2019-01-17 22:27:39 +0100 |
| commit | 248b57015f35c94d4eae2fdd8c6febf5cd703900 (patch) | |
| tree | 880652e44f82321bb1c3130f2636b42ce80d2b2a /drivers/leds/leds-lp5523.c | |
| parent | Linux 5.0-rc1 (diff) | |
| download | linux-248b57015f35c94d4eae2fdd8c6febf5cd703900.tar.xz linux-248b57015f35c94d4eae2fdd8c6febf5cd703900.zip | |
leds: lp5523: fix a missing check of return value of lp55xx_read
When lp55xx_read() fails, "status" is an uninitialized variable and thus
may contain random value; using it leads to undefined behaviors.
The fix inserts a check for the return value of lp55xx_read: if it
fails, returns with its error code.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/leds/leds-lp5523.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index a2e74feee2b2..fd64df5a57a5 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -318,7 +318,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) /* Let the programs run for couple of ms and check the engine status */ usleep_range(3000, 6000); - lp55xx_read(chip, LP5523_REG_STATUS, &status); + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); + if (ret) + return ret; status &= LP5523_ENG_STATUS_MASK; if (status != LP5523_ENG_STATUS_MASK) { |