diff options
| author | Andy Shevchenko <andy.shevchenko@gmail.com> | 2021-05-29 13:19:33 +0200 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2021-08-03 23:49:31 +0200 |
| commit | 7e1baaaa2407a642ea19b58e214fab9a69cda1d7 (patch) | |
| tree | 783bac11c623c47404d5182615352725c0d8fe64 /drivers/leds/leds-lt3593.c | |
| parent | leds: lm3697: Make error handling more robust (diff) | |
| download | linux-7e1baaaa2407a642ea19b58e214fab9a69cda1d7.tar.xz linux-7e1baaaa2407a642ea19b58e214fab9a69cda1d7.zip | |
leds: lt3593: Put fwnode in any case during ->probe()
device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.
Fixes: 8cd7d6daba93 ("leds: lt3593: Add device tree probing glue")
Cc: Daniel Mack <daniel@zonque.org>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds/leds-lt3593.c')
| -rw-r--r-- | drivers/leds/leds-lt3593.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index 3bb52d3165d9..d0160fde0f94 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c @@ -97,10 +97,9 @@ static int lt3593_led_probe(struct platform_device *pdev) init_data.default_label = ":"; ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data); - if (ret < 0) { - fwnode_handle_put(child); + fwnode_handle_put(child); + if (ret < 0) return ret; - } platform_set_drvdata(pdev, led_data); |