diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2020-08-26 16:50:13 +0200 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2020-09-09 11:20:10 +0200 |
| commit | 03eb2ca44a95105d1482d5e7471016cf8b383f97 (patch) | |
| tree | a03fe53ad24ab65ae8dde4267edd0f15ff300d37 /drivers/leds/leds-tlc591xx.c | |
| parent | leds: sgm3140: Simplify with dev_err_probe() (diff) | |
| download | linux-03eb2ca44a95105d1482d5e7471016cf8b383f97.tar.xz linux-03eb2ca44a95105d1482d5e7471016cf8b383f97.zip | |
leds: tlc591xx: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds/leds-tlc591xx.c')
| -rw-r--r-- | drivers/leds/leds-tlc591xx.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c index 0929f1275814..1dc14051639c 100644 --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -213,12 +213,10 @@ tlc591xx_probe(struct i2c_client *client, led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS; err = devm_led_classdev_register_ext(dev, &led->ldev, &init_data); - if (err < 0) { - if (err != -EPROBE_DEFER) - dev_err(dev, "couldn't register LED %s\n", - led->ldev.name); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, + "couldn't register LED %s\n", + led->ldev.name); } return 0; } |