summaryrefslogtreecommitdiffstats
path: root/drivers/leds/leds-turris-omnia.c
diff options
context:
space:
mode:
authorMarek BehĂșn <marek.behun@nic.cz>2020-09-18 00:32:57 +0200
committerPavel Machek <pavel@ucw.cz>2020-09-26 21:56:39 +0200
commit2c67756254349d2b4a1af92c846e32f7e15fae89 (patch)
tree6c2344683d2a4d93ed9c9d8fee7708858a2a6f4b /drivers/leds/leds-turris-omnia.c
parentleds: various: use only available OF children (diff)
downloadlinux-2c67756254349d2b4a1af92c846e32f7e15fae89.tar.xz
linux-2c67756254349d2b4a1af92c846e32f7e15fae89.zip
leds: various: fix OF node leaks
Fix OF node leaks by calling of_node_put in for_each_available_child_of_node when the cycle breaks or returns. Signed-off-by: Marek BehĂșn <marek.behun@nic.cz> Cc: Nikita Travkin <nikitos.tr@gmail.com> Cc: Milo Kim <milo.kim@ti.com> Cc: Dan Murphy <dmurphy@ti.com> Signed-off-by: Pavel Machek <pavel@ucw.cz> Not-for-stable: untested, theoretical, insignificant leaks
Diffstat (limited to 'drivers/leds/leds-turris-omnia.c')
-rw-r--r--drivers/leds/leds-turris-omnia.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index ea7da8517220..117976cf75c8 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -236,8 +236,10 @@ static int omnia_leds_probe(struct i2c_client *client,
led = &leds->leds[0];
for_each_available_child_of_node(np, child) {
ret = omnia_led_register(client, led, child);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(child);
return ret;
+ }
led += ret;
}