diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-03-28 00:26:38 +0100 |
|---|---|---|
| committer | Richard Purdie <rpurdie@linux.intel.com> | 2009-04-06 17:06:26 +0200 |
| commit | b0edba7ef89a64614e40023bf87ed5b402834e04 (patch) | |
| tree | 66fecc06bf1b3a6bffc8eee1d88d6aa0beb821fb /drivers/leds | |
| parent | leds: remove an unnecessary "goto" on drivers/leds/leds-s3c24.c (diff) | |
| download | linux-b0edba7ef89a64614e40023bf87ed5b402834e04.tar.xz linux-b0edba7ef89a64614e40023bf87ed5b402834e04.zip | |
leds: move h1940-leds's probe function to .devinit.text
A pointer to h1940leds_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-h1940.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/leds-h1940.c b/drivers/leds/leds-h1940.c index 11b77a70bbcb..1aa46a390a0d 100644 --- a/drivers/leds/leds-h1940.c +++ b/drivers/leds/leds-h1940.c @@ -104,7 +104,7 @@ static struct led_classdev h1940_blueled = { .default_trigger = "h1940-bluetooth", }; -static int __init h1940leds_probe(struct platform_device *pdev) +static int __devinit h1940leds_probe(struct platform_device *pdev) { int ret; |