diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2021-02-04 16:39:44 +0100 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2021-02-14 18:01:41 +0100 |
| commit | dbeb02a0bc41b9e9b9c05e460890351efecf1352 (patch) | |
| tree | bd5d0ca6df22385d6a9a576f69e1e252b4b5692d /drivers/leds | |
| parent | Linux 5.11-rc7 (diff) | |
| download | linux-dbeb02a0bc41b9e9b9c05e460890351efecf1352.tar.xz linux-dbeb02a0bc41b9e9b9c05e460890351efecf1352.zip | |
leds: rt8515: add V4L2_FLASH_LED_CLASS dependency
The leds-rt8515 driver can optionall use the v4l2 flash led class,
but it causes a link error when that class is in a loadable module
and the rt8515 driver itself is built-in:
ld.lld: error: undefined symbol: v4l2_flash_init
>>> referenced by leds-rt8515.c
>>> leds/flash/leds-rt8515.o:(rt8515_probe) in archive
drivers/built-in.a
Adding 'depends on V4L2_FLASH_LED_CLASS' in Kconfig would avoid that,
but it would make it impossible to use the driver without the
v4l2 support.
Add the same dependency that the other users of this class have
instead, which just prevents the broken configuration.
Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/flash/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig index d21d273ef3da..b580b416b9a4 100644 --- a/drivers/leds/flash/Kconfig +++ b/drivers/leds/flash/Kconfig @@ -5,6 +5,7 @@ if LEDS_CLASS_FLASH config LEDS_RT8515 tristate "LED support for Richtek RT8515 flash/torch LED" depends on GPIOLIB + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS help This option enables support for the Richtek RT8515 flash and torch LEDs found on some mobile phones. |