diff options
| author | Javier González <jg@lightnvm.io> | 2017-04-22 01:32:47 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-04-24 00:57:52 +0200 |
| commit | 33db9fd46ea8e3e6d4757d99a3f97bd1a0c919f3 (patch) | |
| tree | e208433154c5ed4f4bbe9ede6eed20032324b6a4 /drivers/lightnvm | |
| parent | lightnvm: pblk: fix bad error check (diff) | |
| download | linux-33db9fd46ea8e3e6d4757d99a3f97bd1a0c919f3.tar.xz linux-33db9fd46ea8e3e6d4757d99a3f97bd1a0c919f3.zip | |
lightnvm: pblk: fix memory leak on error path
When write recovery fails, Free memory for the recovery structure.
Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"
Signed-off-by: Javier González <javier@cnexlabs.com>
Reviewed-by: Matias Bjørling <matias@cnexlabs.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/lightnvm')
| -rw-r--r-- | drivers/lightnvm/pblk-write.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c index 74f7413a6b20..a896190c82f0 100644 --- a/drivers/lightnvm/pblk-write.c +++ b/drivers/lightnvm/pblk-write.c @@ -142,6 +142,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) /* Logic error */ if (bit > c_ctx->nr_valid) { WARN_ONCE(1, "pblk: corrupted write request\n"); + mempool_free(recovery, pblk->rec_pool); goto out; } @@ -149,6 +150,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) entry = pblk_rb_sync_scan_entry(&pblk->rwb, &ppa); if (!entry) { pr_err("pblk: could not scan entry on write failure\n"); + mempool_free(recovery, pblk->rec_pool); goto out; } @@ -162,6 +164,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) ret = pblk_recov_setup_rq(pblk, c_ctx, recovery, comp_bits, c_entries); if (ret) { pr_err("pblk: could not recover from write failure\n"); + mempool_free(recovery, pblk->rec_pool); goto out; } |