diff options
author | Rob Herring <robh@kernel.org> | 2018-12-05 20:50:28 +0100 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2018-12-22 11:29:56 +0100 |
commit | f1e0addca8bd7386f8cabbc64c9988fff91c131f (patch) | |
tree | 86accf6f05d6b6e05457436f08783e8f460f494a /drivers/macintosh/ans-lcd.c | |
parent | ide: Use of_node_name_eq for node name comparisons (diff) | |
download | linux-f1e0addca8bd7386f8cabbc64c9988fff91c131f.tar.xz linux-f1e0addca8bd7386f8cabbc64c9988fff91c131f.zip |
macintosh: Use of_node_name_{eq, prefix} for node name comparisons
Convert string compares of DT node names to use of_node_name_{eq,prefix}
helpers instead. This removes direct access to the node name pointer.
This changes a single case insensitive node name comparison to case
sensitive for "ata4". This is the only instance of a case insensitive
comparison for all the open coded node name comparisons on powerpc.
Searching the commit history, there doesn't appear to be any reason for
it to be case insensitive.
A couple of open coded iterating thru the child node names are converted
to use for_each_child_of_node() instead.
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/macintosh/ans-lcd.c')
-rw-r--r-- | drivers/macintosh/ans-lcd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c index c8e078b911c7..ef0c2366cf59 100644 --- a/drivers/macintosh/ans-lcd.c +++ b/drivers/macintosh/ans-lcd.c @@ -160,7 +160,7 @@ anslcd_init(void) struct device_node* node; node = of_find_node_by_name(NULL, "lcd"); - if (!node || !node->parent || strcmp(node->parent->name, "gc")) { + if (!node || !of_node_name_eq(node->parent, "gc")) { of_node_put(node); return -ENODEV; } |