diff options
| author | d binderman <dcb314@hotmail.com> | 2010-03-19 00:01:42 +0100 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-04-07 10:00:38 +0200 |
| commit | 6d1bdd2afbed74b3adcf3a7aec49e430eeb6c5f3 (patch) | |
| tree | 051d1706de2a7e25fbd913ae67fe8150ff708f00 /drivers/macintosh | |
| parent | powerpc/pmac/low_i2c.c: three minor problems (diff) | |
| download | linux-6d1bdd2afbed74b3adcf3a7aec49e430eeb6c5f3.tar.xz linux-6d1bdd2afbed74b3adcf3a7aec49e430eeb6c5f3.zip | |
powerpc/pmac/windfarm: Don't test pointers before kfree()
Fix minor nits found by cppcheck
[./macintosh/windfarm_pm81.c:760]: (style) Redundant condition. It is safe to deallocate a NULL pointer
[./macintosh/windfarm_pm81.c:762]: (style) Redundant condition. It is safe to deallocate a NULL pointer
Signed-off-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers/macintosh')
| -rw-r--r-- | drivers/macintosh/windfarm_pm81.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm_pm81.c index 565d5b2adc95..e6e46a227698 100644 --- a/drivers/macintosh/windfarm_pm81.c +++ b/drivers/macintosh/windfarm_pm81.c @@ -757,10 +757,8 @@ static int __devexit wf_smu_remove(struct platform_device *ddev) wf_put_control(cpufreq_clamp); /* Destroy control loops state structures */ - if (wf_smu_sys_fans) - kfree(wf_smu_sys_fans); - if (wf_smu_cpu_fans) - kfree(wf_smu_cpu_fans); + kfree(wf_smu_sys_fans); + kfree(wf_smu_cpu_fans); return 0; } |