diff options
| author | Josh Durgin <josh.durgin@inktank.com> | 2013-08-30 02:36:03 +0200 |
|---|---|---|
| committer | Josh Durgin <josh.durgin@inktank.com> | 2013-09-09 20:16:02 +0200 |
| commit | 20e0af67ce88c657d0601977b9941a2256afbdaa (patch) | |
| tree | 850fb98180ca9a41b600fe444b7d615146c5b1ed /drivers/macintosh | |
| parent | rbd: complete notifies before cleaning up osd_client and rbd_dev (diff) | |
| download | linux-20e0af67ce88c657d0601977b9941a2256afbdaa.tar.xz linux-20e0af67ce88c657d0601977b9941a2256afbdaa.zip | |
rbd: make rbd_obj_notify_ack() synchronous
The only user of rbd_obj_notify_ack() is rbd_watch_cb(). It used
asynchronously with no tracking of when the notify ack completes, so
it may still be in progress when the osd_client is shut down. This
results in a BUG() since the osd client assumes no requests are in
flight when it stops. Since all notifies are flushed before the
osd_client is stopped, waiting for the notify ack to complete before
returning from the watch callback ensures there are no notify acks in
flight during shutdown.
Rename rbd_obj_notify_ack() to rbd_obj_notify_ack_sync() to reflect
its new synchronous nature.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Diffstat (limited to 'drivers/macintosh')
0 files changed, 0 insertions, 0 deletions