summaryrefslogtreecommitdiffstats
path: root/drivers/mailbox
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-01-24 00:53:45 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2014-01-24 01:36:53 +0100
commit4a102b4d144f0422eb8b0a59c7cb194bf12163a9 (patch)
tree8eeb86f4a8af5b267876bf749d959d154ee1b68c /drivers/mailbox
parentasm/types.h: Remove include/asm-generic/int-l64.h (diff)
downloadlinux-4a102b4d144f0422eb8b0a59c7cb194bf12163a9.tar.xz
linux-4a102b4d144f0422eb8b0a59c7cb194bf12163a9.zip
drivers/mailbox/omap: make mbox->irq signed for error handling
There is a bug in omap2_mbox_probe() where we try do: mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) { The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Suman Anna <s-anna@ti.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Omar Ramirez Luna <omar.ramirez@copitl.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/mailbox')
-rw-r--r--drivers/mailbox/omap-mbox.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mailbox/omap-mbox.h b/drivers/mailbox/omap-mbox.h
index 6cd38fc68599..86d7518cd13b 100644
--- a/drivers/mailbox/omap-mbox.h
+++ b/drivers/mailbox/omap-mbox.h
@@ -52,7 +52,7 @@ struct omap_mbox_queue {
struct omap_mbox {
const char *name;
- unsigned int irq;
+ int irq;
struct omap_mbox_queue *txq, *rxq;
struct omap_mbox_ops *ops;
struct device *dev;