summaryrefslogtreecommitdiffstats
path: root/drivers/mailbox
diff options
context:
space:
mode:
authorJonathan Marek <jonathan@marek.ca>2023-08-02 15:52:22 +0200
committerJassi Brar <jaswinder.singh@linaro.org>2023-09-05 17:11:01 +0200
commita493208079e299aefdc15169dc80e3da3ebb718a (patch)
tree5f30b229679c46a998f7795b35ce2be8052b69cc /drivers/mailbox
parentmailbox: Explicitly include correct DT includes (diff)
downloadlinux-a493208079e299aefdc15169dc80e3da3ebb718a.tar.xz
linux-a493208079e299aefdc15169dc80e3da3ebb718a.zip
mailbox: qcom-ipcc: fix incorrect num_chans counting
Breaking out early when a match is found leads to an incorrect num_chans value when more than one ipcc mailbox channel is used by the same device. Fixes: e9d50e4b4d04 ("mailbox: qcom-ipcc: Dynamic alloc for channel arrangement") Signed-off-by: Jonathan Marek <jonathan@marek.ca> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox')
-rw-r--r--drivers/mailbox/qcom-ipcc.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
index 7e27acf6c0cc..f597a1bd5684 100644
--- a/drivers/mailbox/qcom-ipcc.c
+++ b/drivers/mailbox/qcom-ipcc.c
@@ -227,10 +227,8 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
ret = of_parse_phandle_with_args(client_dn, "mboxes",
"#mbox-cells", j, &curr_ph);
of_node_put(curr_ph.np);
- if (!ret && curr_ph.np == controller_dn) {
+ if (!ret && curr_ph.np == controller_dn)
ipcc->num_chans++;
- break;
- }
}
}