diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-07-27 12:41:37 +0200 |
|---|---|---|
| committer | Jassi Brar <jaswinder.singh@linaro.org> | 2023-09-05 17:10:42 +0200 |
| commit | 65d9aa3191432ec672f32291b047a00fe67d71cc (patch) | |
| tree | 66e84846a05d77f10d9f80bc6689cb037426e5c8 /drivers/mailbox | |
| parent | mailbox: bcm-pdc: Fix some kernel-doc comments (diff) | |
| download | linux-65d9aa3191432ec672f32291b047a00fe67d71cc.tar.xz linux-65d9aa3191432ec672f32291b047a00fe67d71cc.zip | |
mailbox: platform-mhu: Remove redundant dev_err()
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox')
| -rw-r--r-- | drivers/mailbox/platform_mhu.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/mailbox/platform_mhu.c b/drivers/mailbox/platform_mhu.c index a5922ac0b0bf..176ce290b8a8 100644 --- a/drivers/mailbox/platform_mhu.c +++ b/drivers/mailbox/platform_mhu.c @@ -135,10 +135,8 @@ static int platform_mhu_probe(struct platform_device *pdev) for (i = 0; i < MHU_CHANS; i++) { mhu->chan[i].con_priv = &mhu->mlink[i]; mhu->mlink[i].irq = platform_get_irq(pdev, i); - if (mhu->mlink[i].irq < 0) { - dev_err(dev, "failed to get irq%d\n", i); + if (mhu->mlink[i].irq < 0) return mhu->mlink[i].irq; - } mhu->mlink[i].rx_reg = mhu->base + platform_mhu_reg[i]; mhu->mlink[i].tx_reg = mhu->mlink[i].rx_reg + TX_REG_OFFSET; } |