diff options
| author | Joe Thornber <ejt@redhat.com> | 2012-12-21 21:23:31 +0100 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2012-12-21 21:23:31 +0100 |
| commit | b7ca9c9273e5eebd63880dd8a6e4e5c18fc7901d (patch) | |
| tree | 8022d8d5f6f03d80896407562b48c554a8cbfa6f /drivers/md/dm-bio-prison.h | |
| parent | dm: disable WRITE SAME (diff) | |
| download | linux-b7ca9c9273e5eebd63880dd8a6e4e5c18fc7901d.tar.xz linux-b7ca9c9273e5eebd63880dd8a6e4e5c18fc7901d.zip | |
dm thin: replace dm_cell_release_singleton with cell_defer_except
Change existing users of the function dm_cell_release_singleton to share
cell_defer_except instead, and then remove the now-unused function.
Everywhere that calls dm_cell_release_singleton, the bio in question
is the holder of the cell.
If there are no non-holder entries in the cell then cell_defer_except
behaves exactly like dm_cell_release_singleton. Conversely, if there
*are* non-holder entries then dm_cell_release_singleton must not be used
because those entries would need to be deferred.
Consequently, it is safe to replace use of dm_cell_release_singleton
with cell_defer_except.
This patch is a pre-requisite for "dm thin: fix race between
simultaneous io and discards to same block".
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/md/dm-bio-prison.h')
| -rw-r--r-- | drivers/md/dm-bio-prison.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/dm-bio-prison.h b/drivers/md/dm-bio-prison.h index 4e0ac376700a..53d1a7a84e2f 100644 --- a/drivers/md/dm-bio-prison.h +++ b/drivers/md/dm-bio-prison.h @@ -44,7 +44,6 @@ int dm_bio_detain(struct dm_bio_prison *prison, struct dm_cell_key *key, struct bio *inmate, struct dm_bio_prison_cell **ref); void dm_cell_release(struct dm_bio_prison_cell *cell, struct bio_list *bios); -void dm_cell_release_singleton(struct dm_bio_prison_cell *cell, struct bio *bio); // FIXME: bio arg not needed void dm_cell_release_no_holder(struct dm_bio_prison_cell *cell, struct bio_list *inmates); void dm_cell_error(struct dm_bio_prison_cell *cell); |