diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2018-07-03 20:13:25 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2018-07-27 21:24:20 +0200 |
| commit | c21b16392701543d61e366dca84e15fe7f0cf0cf (patch) | |
| tree | 894be88cee90fcb91241fc2042a8bb68acf2f9f6 /drivers/md/dm-integrity.c | |
| parent | dm delay: add flush as a third class of IO (diff) | |
| download | linux-c21b16392701543d61e366dca84e15fe7f0cf0cf.tar.xz linux-c21b16392701543d61e366dca84e15fe7f0cf0cf.zip | |
dm integrity: change 'suspending' variable from bool to int
Early alpha processors can't write a byte or short atomically - they
read 8 bytes, modify the byte or two bytes in registers and write back
8 bytes.
The modification of the variable "suspending" may race with
modification of the variable "failed". Fix this by changing
"suspending" to an int.
Cc: stable@vger.kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-integrity.c')
| -rw-r--r-- | drivers/md/dm-integrity.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c index 86438b2f10dd..0a8a4c2aa3ea 100644 --- a/drivers/md/dm-integrity.c +++ b/drivers/md/dm-integrity.c @@ -178,7 +178,7 @@ struct dm_integrity_c { __u8 sectors_per_block; unsigned char mode; - bool suspending; + int suspending; int failed; @@ -2210,7 +2210,7 @@ static void dm_integrity_postsuspend(struct dm_target *ti) del_timer_sync(&ic->autocommit_timer); - ic->suspending = true; + WRITE_ONCE(ic->suspending, 1); queue_work(ic->commit_wq, &ic->commit_work); drain_workqueue(ic->commit_wq); @@ -2220,7 +2220,7 @@ static void dm_integrity_postsuspend(struct dm_target *ti) dm_integrity_flush_buffers(ic); } - ic->suspending = false; + WRITE_ONCE(ic->suspending, 0); BUG_ON(!RB_EMPTY_ROOT(&ic->in_progress)); |