diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2019-08-23 15:55:26 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2019-08-23 16:13:12 +0200 |
| commit | 123d87d553e26f67e7be318c97c971b6b5fb1daa (patch) | |
| tree | 874e61dd6809114c3b5186c2d7e0fc25a43b3662 /drivers/md/dm-ioctl.c | |
| parent | dm table: fix invalid memory accesses with too high sector number (diff) | |
| download | linux-123d87d553e26f67e7be318c97c971b6b5fb1daa.tar.xz linux-123d87d553e26f67e7be318c97c971b6b5fb1daa.zip | |
dm: make dm_table_find_target return NULL
Currently, if we pass too high sector number to dm_table_find_target, it
returns zeroed dm_target structure and callers test if the structure is
zeroed with the macro dm_target_is_valid.
However, returning NULL is common practice to indicate errors.
This patch refactors the dm code, so that dm_table_find_target returns
NULL and its callers test the returned value for NULL. The macro
dm_target_is_valid is deleted. In alloc_targets, we no longer allocate an
extra zeroed target.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-ioctl.c')
| -rw-r--r-- | drivers/md/dm-ioctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 1e03bc89e20f..fb6f8fb1f13d 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1592,7 +1592,7 @@ static int target_message(struct file *filp, struct dm_ioctl *param, size_t para } ti = dm_table_find_target(table, tmsg->sector); - if (!dm_target_is_valid(ti)) { + if (!ti) { DMWARN("Target message sector outside device."); r = -EINVAL; } else if (ti->type->message) |