diff options
| author | Vivek Goyal <vgoyal@redhat.com> | 2015-07-31 15:20:36 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2015-08-12 17:32:21 +0200 |
| commit | e80d1c805a3b2f0ad2081369be5dc5deedd5ee59 (patch) | |
| tree | 9e1044dc46f00ac0e2c34f92c6c10189c89f0ce9 /drivers/md/dm-stripe.c | |
| parent | dm: test return value for DM_MAPIO_SUBMITTED (diff) | |
| download | linux-e80d1c805a3b2f0ad2081369be5dc5deedd5ee59.tar.xz linux-e80d1c805a3b2f0ad2081369be5dc5deedd5ee59.zip | |
dm: do not override error code returned from dm_get_device()
Some of the device mapper targets override the error code returned by
dm_get_device() and return either -EINVAL or -ENXIO. There is nothing
gained by this override. It is better to propagate the returned error
code unchanged to caller.
This work was motivated by hitting an issue where the underlying device
was busy but -EINVAL was being returned. After this change we get
-EBUSY instead and it is easier to figure out the problem.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-stripe.c')
| -rw-r--r-- | drivers/md/dm-stripe.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c index a672a1502c14..9a814a5eb89f 100644 --- a/drivers/md/dm-stripe.c +++ b/drivers/md/dm-stripe.c @@ -75,13 +75,15 @@ static int get_stripe(struct dm_target *ti, struct stripe_c *sc, { unsigned long long start; char dummy; + int ret; if (sscanf(argv[1], "%llu%c", &start, &dummy) != 1) return -EINVAL; - if (dm_get_device(ti, argv[0], dm_table_get_mode(ti->table), - &sc->stripe[stripe].dev)) - return -ENXIO; + ret = dm_get_device(ti, argv[0], dm_table_get_mode(ti->table), + &sc->stripe[stripe].dev); + if (ret) + return ret; sc->stripe[stripe].physical_start = start; |