summaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-switch.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2024-07-11 22:25:21 +0200
committerAndrew Morton <akpm@linux-foundation.org>2024-07-18 06:11:34 +0200
commitf944ffcbc2e1c759764850261670586ddf3bdabb (patch)
tree02e4c2e9c602bb76d4bf7d21693fa0116276c57c /drivers/md/dm-switch.c
parenttsacct: replace strncpy() with strscpy() (diff)
downloadlinux-f944ffcbc2e1c759764850261670586ddf3bdabb.tar.xz
linux-f944ffcbc2e1c759764850261670586ddf3bdabb.zip
watchdog/perf: properly initialize the turbo mode timestamp and rearm counter
For systems on which the performance counter can expire early due to turbo modes the watchdog handler has a safety net in place which validates that since the last watchdog event there has at least 4/5th of the watchdog period elapsed. This works reliably only after the first watchdog event because the per CPU variable which holds the timestamp of the last event is never initialized. So a first spurious event will validate against a timestamp of 0 which results in a delta which is likely to be way over the 4/5 threshold of the period. As this might happen before the first watchdog hrtimer event increments the watchdog counter, this can lead to false positives. Fix this by initializing the timestamp before enabling the hardware event. Reset the rearm counter as well, as that might be non zero after the watchdog was disabled and reenabled. Link: https://lkml.kernel.org/r/87frsfu15a.ffs@tglx Fixes: 7edaeb6841df ("kernel/watchdog: Prevent false positives with turbo modes") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'drivers/md/dm-switch.c')
0 files changed, 0 insertions, 0 deletions