diff options
author | Elena Reshetova <elena.reshetova@intel.com> | 2017-10-20 09:37:38 +0200 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2017-10-24 21:09:51 +0200 |
commit | 2a0b4682e09d76466f7b8f5e347ae2ff02f033af (patch) | |
tree | 1f54fee8c0178790f22468e64f8b2984ffe828de /drivers/md/dm-thin.c | |
parent | Linux 4.14-rc6 (diff) | |
download | linux-2a0b4682e09d76466f7b8f5e347ae2ff02f033af.tar.xz linux-2a0b4682e09d76466f7b8f5e347ae2ff02f033af.zip |
dm: convert dm_dev_internal.count from atomic_t to refcount_t
atomic_t variables are currently used to implement reference
counters with the following properties:
- counter is initialized to 1 using atomic_set()
- a resource is freed upon counter reaching zero
- once counter reaches zero, its further
increments aren't allowed
- counter schema uses basic atomic operations
(set, inc, inc_not_zero, dec_and_test, etc.)
Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.
The variable dm_dev_internal.count is used as pure reference counter.
Convert it to refcount_t and fix up the operations.
Suggested-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-thin.c')
0 files changed, 0 insertions, 0 deletions